Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing includes #21913

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Add missing includes #21913

merged 1 commit into from
Aug 17, 2022

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Aug 16, 2022

Problem

Some files are missing #includes

Change overview

Add them

Testing

Build.

@mspang mspang force-pushed the for-chip/missing-includes2 branch from 15cdaee to 14c09c2 Compare August 16, 2022 08:21
@mspang mspang force-pushed the for-chip/missing-includes2 branch from 14c09c2 to 7ecb8e9 Compare August 16, 2022 08:34
@github-actions
Copy link

github-actions bot commented Aug 16, 2022 •
edited
Loading

PR #21913: Size comparison from 08f0983 to 7ecb8e9

Increases (3 builds for cc13x2_26x2, telink)
platform target config section 08f0983 7ecb8e9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 179160 179168 8 0.0
lock-mtd LP_CC2652R7 (read/write) 180604 180612 8 0.0
telink lighting-app tlsr9518adk80d text 589434 589436 2 0.0
Decreases (3 builds for cc13x2_26x2, telink)
platform target config section 08f0983 7ecb8e9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672351 672343 -8 -0.0
.text 583316 583308 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 656811 656803 -8 -0.0
.text 554600 554592 -8 -0.0
telink light-switch-app tlsr9518adk80d text 571348 571346 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 08f0983 7ecb8e9 change % change
bl602 lighting-app bl602 (read/write) 1383418 1383418 0 0.0
.bss 119906 119906 0 0.0
.data 4480 4480 0 0.0
.text 1050988 1050988 0 0.0
bl602+rpc (read/write) 1428930 1428930 0 0.0
.bss 127346 127346 0 0.0
.data 4600 4600 0 0.0
.text 1082744 1082744 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672351 672343 -8 -0.0
(read/write) 179160 179168 8 0.0
.bss 74404 74404 0 0.0
.data 3372 3372 0 0.0
.rodata 88719 88719 0 0.0
.text 583316 583308 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637727 637727 0 0.0
(read/write) 157980 157980 0 0.0
.bss 73692 73692 0 0.0
.data 3372 3372 0 0.0
.rodata 77951 77951 0 0.0
.text 559452 559452 0 0.0
lock-ftd LP_CC2652R7 (read only) 674059 674059 0 0.0
(read/write) 167668 167668 0 0.0
.bss 71508 71508 0 0.0
.data 3296 3296 0 0.0
.rodata 76643 76643 0 0.0
.text 596936 596936 0 0.0
lock-mtd LP_CC2652R7 (read only) 656811 656803 -8 -0.0
(read/write) 180604 180612 8 0.0
.bss 67196 67196 0 0.0
.data 3296 3296 0 0.0
.rodata 101731 101731 0 0.0
.text 554600 554592 -8 -0.0
pump-app LP_CC2652R7 (read only) 684739 684739 0 0.0
(read/write) 157796 157796 0 0.0
.bss 71548 71548 0 0.0
.data 3296 3296 0 0.0
.rodata 89931 89931 0 0.0
.text 594324 594324 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669231 669231 0 0.0
(read/write) 173424 173424 0 0.0
.bss 71668 71668 0 0.0
.data 3292 3292 0 0.0
.rodata 85487 85487 0 0.0
.text 583264 583264 0 0.0
shell LP_CC2652R7 (read only) 665034 665034 0 0.0
(read/write) 181996 181996 0 0.0
.bss 76724 76724 0 0.0
.data 3376 3376 0 0.0
.rodata 85666 85666 0 0.0
.text 579052 579052 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586070 586070 0 0.0
.app_xip_area 462704 462704 0 0.0
.bss 65800 65800 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591886 591886 0 0.0
.app_xip_area 463736 463736 0 0.0
.bss 70584 70584 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599026 599026 0 0.0
.app_xip_area 476380 476380 0 0.0
.bss 65112 65112 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1100620 1100620 0 0.0
.bss 133020 133020 0 0.0
.data 2068 2068 0 0.0
.text 965512 965512 0 0.0
BRD4161A+rpc (read/write) 1154860 1154860 0 0.0
.bss 149708 149708 0 0.0
.data 2280 2280 0 0.0
.text 1002852 1002852 0 0.0
BRD4161A+rs911x (read/write) 989688 989688 0 0.0
.bss 162344 162344 0 0.0
.data 2056 2056 0 0.0
.text 825268 825268 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139172 1139172 0 0.0
.bss 145520 145520 0 0.0
.data 2064 2064 0 0.0
.text 991568 991568 0 0.0
window-app BRD4161A (read/write) 1092080 1092080 0 0.0
.bss 134460 134460 0 0.0
.data 2096 2096 0 0.0
.text 955504 955504 0 0.0
esp32 all-clusters-app c3devkit (read only) 1029944 1029944 0 0.0
(read/write) 1488650 1488650 0 0.0
.dram0.bss 70864 70864 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217752 217752 0 0.0
.flash.text 1029944 1029944 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1083299 1083299 0 0.0
(read/write) 490608 490608 0 0.0
.dram0.bss 76376 76376 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248092 248092 0 0.0
.flash.text 1077915 1077915 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 645092 645092 0 0.0
.bss 69848 69848 0 0.0
.data 2044 2044 0 0.0
.text 570472 570472 0 0.0
lock k32w0+release (read/write) 702644 702644 0 0.0
.bss 70320 70320 0 0.0
.data 2052 2052 0 0.0
.text 627544 627544 0 0.0
linux all-clusters-app debug (read only) 3034065 3034065 0 0.0
(read/write) 155920 155920 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85560 85560 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 274443 274443 0 0.0
.text 2580546 2580546 0 0.0
all-clusters-minimal-app debug (read only) 2873921 2873921 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274635 274635 0 0.0
.text 2422914 2422914 0 0.0
bridge-app debug+rpc (read only) 2372777 2372777 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203432 203432 0 0.0
.text 2006722 2006722 0 0.0
chip-tool debug (read only) 10725353 10725353 0 0.0
(read/write) 650912 650912 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 615880 615880 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 556213 556213 0 0.0
.text 8663396 8663396 0 0.0
chip-tool-ipv6only arm64 (read only) 10131452 10131452 0 0.0
(read/write) 698657 698657 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643408 643408 0 0.0
.dynamic 560 560 0 0.0
.got 13720 13720 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 487404 487404 0 0.0
.text 8007092 8007092 0 0.0
lighting-app debug+rpc (read only) 2596761 2596761 0 0.0
(read/write) 130176 130176 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72360 72360 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220208 220208 0 0.0
.text 2205842 2205842 0 0.0
lock-app debug (read only) 2580673 2580673 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237264 237264 0 0.0
.text 2176754 2176754 0 0.0
ota-provider-app debug (read only) 2357833 2357833 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209240 209240 0 0.0
.text 1985122 1985122 0 0.0
ota-requestor-app debug (read only) 2523049 2523049 0 0.0
(read/write) 127320 127320 0 0.0
.bss 50336 50336 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68728 68728 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216000 216000 0 0.0
.text 2134482 2134482 0 0.0
shell debug (read only) 2602369 2602369 0 0.0
(read/write) 142040 142040 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77160 77160 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 234546 234546 0 0.0
.text 2209474 2209474 0 0.0
thermostat-no-ble arm64 (read only) 2356964 2356964 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140524 140524 0 0.0
.text 1978720 1978720 0 0.0
tv-app debug (read only) 3173721 3173721 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 258856 258856 0 0.0
.text 2725122 2725122 0 0.0
tv-casting-app debug (read only) 5416113 5416113 0 0.0
(read/write) 159088 159088 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98776 98776 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 342449 342449 0 0.0
.text 4805314 4805314 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 214692 214692 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179683 1179683 0 0.0
bss 143375 143375 0 0.0
rodata 143268 143268 0 0.0
text 814084 814084 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159543 1159543 0 0.0
bss 142612 142612 0 0.0
rodata 134944 134944 0 0.0
text 803072 803072 0 0.0
p6 all-clusters-app default (read only) 881368 881368 0 0.0
(read/write) 1698924 1698924 0 0.0
.bss 149320 149320 0 0.0
.data 2656 2656 0 0.0
.text 1538560 1538560 0 0.0
all-clusters-minimal-app default (read only) 882088 882088 0 0.0
(read/write) 1642932 1642932 0 0.0
.bss 148600 148600 0 0.0
.data 2656 2656 0 0.0
.text 1483288 1483288 0 0.0
light-app default (read only) 890432 890432 0 0.0
(read/write) 1560220 1560220 0 0.0
.bss 140464 140464 0 0.0
.data 2448 2448 0 0.0
.text 1408920 1408920 0 0.0
lock-app default (read only) 885936 885936 0 0.0
(read/write) 1597500 1597500 0 0.0
.bss 144944 144944 0 0.0
.data 2464 2464 0 0.0
.text 1441704 1441704 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808416 808416 0 0.0
bss 71096 71096 0 0.0
noinit 43488 43488 0 0.0
text 571348 571346 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830352 830352 0 0.0
bss 71952 71952 0 0.0
noinit 43488 43488 0 0.0
text 589434 589436 2 0.0

@woody-apple woody-apple enabled auto-merge (squash) August 16, 2022 16:46
@woody-apple woody-apple merged commit c1eafcd into project-chip:master Aug 17, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@mspang @isiu-apple
Add missing includes (project-chip#21913)
6dad644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app examples lib review - approved tests tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mspang @andy31415 @woody-apple